[PATCH] D38722: Added Remarks for Loop Versioning LICM Pass

[Deepak Porwal via Phabricator via llvm-commits]

Deepak_Porwal added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:410
+                                 CurLoop->getStartLoc(), CurLoop->getHeader())
+        << "Runtime checks are more than threshold !!\n");
     return false;
----------------
anemet wrote:
> It's usually useful to output the actual numbers.  See how we do that in Inliner.cpp where we include the cost and the threshold.
> 
> Also please use the new closure API with emit.  Again, see the inliner or https://reviews.llvm.org/D38285.
Working on necessary changes. 

Out of curiosity would like to know the reason for using new Closure API with emit for some places and not for all places (as in Inliner.cpp). 


https://reviews.llvm.org/D38722