[PATCH] D38748: AMDGPU: Add support for isa version note

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:59
+/// \returns Isa version string for given subtarget \p STI.
+std::string getIsaVersionString(const MCSubtargetInfo *STI);
+
----------------
I would expect the API for this to be to pass in the raw_ostream&


================
Comment at: test/CodeGen/AMDGPU/elf-notes.ll:1
+; RUN: llc -march=r600 < %s | FileCheck --check-prefix=R600 %s
+; RUN: llc -mtriple=amdgcn-amd-unknown -mcpu=gfx800 < %s | FileCheck --check-prefix=GCN --check-prefix=OSABI-UNK --check-prefix=GFX800 %s
----------------
Move this last


https://reviews.llvm.org/D38748