[PATCH] D38756: [x86] use an insert op to put one variable element into a constant of vectors

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D38756#893892, @efriedma wrote:

> > I tried to work-around the FP issue by creating a constant pool load, but that got a bit ugly - I had to call LowerConstantPool() to create a legal vector of constants.
>
> Yes, it's a little ugly, but it's self-contained.  I don't have a better suggestion.


Ok - thanks! I'd managed to mostly avoid lowering after all this time by transforming things sooner. :)


https://reviews.llvm.org/D38756