[PATCH] D37638: [IPSCCP] Move common functions to IPOUtils (NFC)

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso updated this revision to Diff 118447.
mssimpso added a comment.

Addressed Danny's comments.

- Rename to ValueLatticeUtils
- Use any_of
- I'll retitle the patch when committing to avoid starting a new thread on llvm-commits.

I think Davide originally suggested moving these helpers out of IPSCCP. I had essentially duplicated them for the CalledValuePropagation pass, and the idea was to eliminate the duplication. However, I do recall that we were unsure of the broader usefulness of the global variables function in particular. I think renaming to ValueLatticeUtils helps address this, though.


https://reviews.llvm.org/D37638

Files:
  include/llvm/Analysis/ValueLatticeUtils.h
  lib/Analysis/CMakeLists.txt
  lib/Analysis/ValueLatticeUtils.cpp
  lib/Transforms/Scalar/SCCP.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37638.118447.patch
Type: text/x-patch
Size: 10083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171010/953d2ff5/attachment.bin>