[PATCH] D38725: [LoopUnroll] Clean up remarks for unroll remainder

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:504
+        ORE->emit(
+            [&]() { return DiagBuilder() << " with run-time trip count"; });
     }
----------------
Do I understand correctly that we want to only display this remark in case the following condition is true, so if we successfully unrolled the loop with a run-time trip count (condition at line 428)?

``` RuntimeTripCount && TripMultiple % Count != 0 && 
      UnrollRuntimeLoopRemainder(....) ```

I am probably missing something, but it seems like this code path does not consider the `TripMultiple % Count != 0` from the condition. 


https://reviews.llvm.org/D38725