[PATCH] D38200: [GISel]: Process new insts to legalize in the order they were created

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 10:40:38 PDT 2017


aditya_nandakumar added a comment.

In https://reviews.llvm.org/D38200#893182, @kristof.beyls wrote:

> > While this shouldn't be an issue (legalization should only look at one instruction), there's some out of tree code that looks at other instructions as well, and this is breaking the legalization for that instruction.
>
> I'm a bit confused by the above. Should we allow legalization to look at other instructions, or should we not?


I might have not framed that sentence correctly. I meant to say I realized about the dependency on legalization order when I added the LegalizationCombiner. I also think that shouldn't be happening here. I was only trying to revert to the original order in this patch, but I agree that it's a dangerous path to go down.


Repository:
  rL LLVM

https://reviews.llvm.org/D38200





More information about the llvm-commits mailing list