[PATCH] D38719: [llvm-dwarfdump] Verify compatible TAG for attributes.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 10:09:27 PDT 2017


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with outstanding nitpicks addressed and assuming David is happy with the patch.



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:434
+      error() << "DIE has incompatible " << AttributeString(Attr)
+              << " encoding: " << TagString(Die.getTag()) << " and " << TagString(SpecDie.getTag()) << "";
+      Die.dump(OS, 0, DumpOpts);
----------------
`<< ""` ?


https://reviews.llvm.org/D38719





More information about the llvm-commits mailing list