[PATCH] D37736: [ELF] - Do not spread specific flags when emiting output sections.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 09:30:23 PDT 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> +  // The other option is to pick flags that minimize the impact the section
> +  // will have on the rest of the linker. That is why we copy the flags from
> +  // the previous sections. That was simplistic, as only a few flags are needed
> +  // to keep the impact low, and copying more esoteric flags like SHF_LINK_ORDER
> +  // have the opposite effect: it causes undesirable effects on the rest of the
> +  // link.

The "that was simplistic" part sounds odd as a code comment. One the
original email it was describing a change, but as a code comment it
should describe the new state.

Cheers,
Rafael


More information about the llvm-commits mailing list