[llvm] r314915 - [test] Fix append_path in the empty case

Francis Ricci via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 09:12:51 PDT 2017


Thanks for catching this!

On Tue, Oct 10, 2017 at 12:11 PM, Bruno Cardoso Lopes
<bruno.cardoso at gmail.com> wrote:
> On Tue, Oct 10, 2017 at 7:00 AM, Francis Ricci <francisjricci at gmail.com> wrote:
>> From lib/sanitizer_common/sanitizer_flag_parser.cc:
>>
>> bool FlagParser::is_space(char c) {
>> return c == ' ' || c == ',' || c == ':' || c == '\n' || c == '\t' ||
>> c == '\r';
>> }
>
> Cool! I'll change the option to be quoted then. Thanks!
>
>> On Mon, Oct 9, 2017 at 8:17 PM, Bruno Cardoso Lopes
>> <bruno.cardoso at gmail.com> wrote:
>>> On Mon, Oct 9, 2017 at 3:09 PM, Francis Ricci <francisjricci at gmail.com> wrote:
>>>> Hmm, ":" should definitely be a valid separator, unless some extra
>>>> quotes are getting added in somewhere that shouldn't be. What's the
>>>> actual ASAN_OPTIONS string you're seeing?
>>>
>>> Like I mentioned above, I don't see ":" handling in ASAN_OPTIONS env
>>> parse code. Looking at parse_flags() in
>>> lib/sanitizer_common/sanitizer_flag_parser.cc, it looks to me like the
>>> only acceptable separator is a whitespace. But I might be missing
>>> something. My question is: where did you find that ":" is valid?
>>>
>>> --
>>> Bruno Cardoso Lopes
>>> http://www.brunocardoso.cc
>
>
>
> --
> Bruno Cardoso Lopes
> http://www.brunocardoso.cc


More information about the llvm-commits mailing list