[PATCH] D36508: [ELF] - Linkerscript: Add `~` as separate math token.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Ah, sorry, I missed the first line of your last comment.
>
>
>
> ================
> Comment at: ELF/ScriptLexer.cpp:171
>  static std::vector<StringRef> tokenizeExpr(StringRef S) {
> -  StringRef Ops = "+-*/:"; // List of operators
> +  StringRef Ops = "+-*/:~"; // List of operators
>  
> ----------------
> I'd think you should spend a little more time on each patch. Apparently, you need to update the following comment that assumes `+-*/` is a list of operators.

I would probably delete the second comment on line 177. Duplicated
comments are very easy to get out of sync.

Cheers,
Rafael