[PATCH] D38190: Partial Inlining with multi-region outlining based on PGO information

[Graham Yiu via Phabricator via llvm-commits]

gyiu added inline comments.


================
Comment at: lib/Transforms/IPO/PartialInlining.cpp:168-169
   struct FunctionCloner {
+    // Constructor with FunctionOutliningInfo should be removed once
+    // multi-region outlining work is complete.
     FunctionCloner(Function *F, FunctionOutliningInfo *OI);
----------------
echristo wrote:
> When is this?
This is a leftover comment that's no longer valid.  We'll need to keep both constructors.  However, there's a refinement to how we track outlined functions that is now redundant (class members OutlinedFunctions vs. OutlinedFunc+OutliningCallBB), so I'll make that change now.


Repository:
  rL LLVM

https://reviews.llvm.org/D38190