[PATCH] D38732: [X86][AVX512] Improve lowering of AVX512 test intrinsics

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:457
+      N->getOpcode() == X86ISD::TESTNM ||
       N->getOpcode() == X86ISD::CMPMU) {
     // We can get 256-bit 8 element types here without VLX being enabled. When
----------------
Pull out repeated N->getOpcode()
```
unsigned Opcode = N->getOpcode();
if (Opcode == X86ISD::PCMPEQM || Opcode == X86ISD::PCMPGTM ||
    Opcode == X86ISD::TESTM || Opcode == X86ISD::TESTNM ||
    Opcode == X86ISD::CMPM || Opcode == X86ISD::CMPMU) {
```


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:462
     if (N->getOperand(0).getValueType() == MVT::v8i32 ||
         N->getOperand(0).getValueType() == MVT::v8f32)
       return Subtarget->hasVLX();
----------------
```
EVT OpVT = N->getOperand(0).getValueType();
if (OpVT == MVT::v8i32 || OpVT == MVT::v8f32)
```


https://reviews.llvm.org/D38732