[PATCH] D38379: Classify llvm-cfi-verify.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-cfi-verify/FileAnalysis.cpp:257
+void FileAnalysis::addInstruction(const Instr &Instruction) {
+  Instructions[Instruction.VMAddress] = Instruction;
+}
----------------
Is it useful to assert() that an instruction isn't being overwritten here?


================
Comment at: tools/llvm-cfi-verify/FileAnalysis.h:140
+  // A list of addresses of indirect control flow instructions.
+  std::set<uint64_t> IndirectInstructions;
+};
----------------
hctim wrote:
> vlad.tsyrklevich wrote:
> > I kept coming back to this trying to figure out what IndirectInstructions were, rename to IndirectBranches/getIndirectBranches()?
> I've been trying to keep the rhetoric 'indirect instructions' to cover both indirect branches and indirect calls.
> 
> Would you prefer IndirectCallsAndJumps?
It's a bit unwieldy, lets leave as is.


https://reviews.llvm.org/D38379