[PATCH] D38719: [llvm-dwarfdump] Verify compatible TAG for attributes.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:423
+    // Make sure specification and abstract origin have compatible tag.
+    if (auto Offset = AttrValue.Value.getAsReference()) {
+
----------------
Can you use DWARFDie::getAttributeValueAsReferencedDie here, perhaps?


================
Comment at: test/tools/llvm-dwarfdump/X86/verify_compatible_tags.s:23-24
+# CHECK: error: DIE has incompatible DW_AT_abstract_origin encoding:
+# CHECK: DW_TAG_subprogram
+# CHECK: DW_TAG_base_type
+
----------------
Maybe this should have some more words about which one was expected & which one was actually found? (& maybe dumping whose DIEs or some reference to the DIE so the user knows where to look in the DWARF to find the DIEs in question?)


Repository:
  rL LLVM

https://reviews.llvm.org/D38719