[PATCH] D38021: [Compiler-rt][MIPS] Fix cross build for XRAY

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 05:53:47 PDT 2017


dberris added a comment.

The patch seems ill-formed -- usually you want to create the patch from the root of the project. In this case it will be from the root of the compiler-rt repository/working copy.



================
Comment at: CMakeLists.txt:273
+  separate_arguments(CROSS_COMPILE_FLAGS)
+  list(APPEND SANITIZER_COMMON_CFLAGS ${CROSS_COMPILE_FLAGS})
+endif()
----------------
Do you still really need this if you just use `cmake -DCMAKE_CXX_FLAGS=...` without this change? What happens when you revert this change and provide the target flags instead when you invoke cmake?


https://reviews.llvm.org/D38021





More information about the llvm-commits mailing list