[PATCH] D38128: Handle COPYs of physregs better (regalloc hints)

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 118343.
jonpa added a comment.
Herald added subscribers: javed.absar, nhaehnle.

Thanks for review, Quentin.

I have now begun to undertake the task of updating all the tests for the various targets. Since it is quite clear (at least on SystemZ) that the multiple regalloc copy hints result in less COPYs, I hope that the target test owners help me reviewing the test changes as I go along, so that I can commit this patch.

- SystemZ:
  - call-03.ll / f5 which was expected to fail when enabling mischeduler, is now passing again. The check for the extra COPY is removed.
  - call-args-coalesce.mir removed, as it was derived from the call-03.ll/f5 failure.

- AArch64: tests updated - needs review

- AMDGPU: ~ a dozen of files updated. There are more files that need updating, but after this many tests updated, I need some review on this before I continue. In particular I see a lot of vcc defs/uses turning into e.g. s[0:1], which I am not sure is acceptable.




https://reviews.llvm.org/D38128

Files:
  include/llvm/CodeGen/MachineRegisterInfo.h
  include/llvm/Target/TargetRegisterInfo.h
  lib/CodeGen/CalcSpillWeights.cpp
  lib/CodeGen/TargetRegisterInfo.cpp
  test/CodeGen/AArch64/arm64-aapcs.ll
  test/CodeGen/AArch64/func-argpassing.ll
  test/CodeGen/AArch64/swifterror.ll
  test/CodeGen/AArch64/win64_vararg.ll
  test/CodeGen/AMDGPU/addrspacecast.ll
  test/CodeGen/AMDGPU/anyext.ll
  test/CodeGen/AMDGPU/branch-condition-and.ll
  test/CodeGen/AMDGPU/branch-relaxation.ll
  test/CodeGen/AMDGPU/callee-special-input-sgprs.ll
  test/CodeGen/AMDGPU/callee-special-input-vgprs.ll
  test/CodeGen/AMDGPU/cf-loop-on-constant.ll
  test/CodeGen/AMDGPU/cndmask-no-def-vcc.ll
  test/CodeGen/AMDGPU/collapse-endcf.ll
  test/CodeGen/AMDGPU/commute-compares.ll
  test/CodeGen/AMDGPU/ctlz.ll
  test/CodeGen/AMDGPU/ctlz_zero_undef.ll
  test/CodeGen/AMDGPU/fcmp.f16.ll
  test/CodeGen/SystemZ/call-03.ll
  test/CodeGen/SystemZ/swift-return.ll
  test/CodeGen/SystemZ/swifterror.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38128.118343.patch
Type: text/x-patch
Size: 77965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171010/0ab1a71a/attachment-0001.bin>