[PATCH] D38689: [X86] Fix a bug with i386 subtarget in LowerCONCAT_VECTORSvXi1 func

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 04:17:01 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.

LGTM with one minor



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:8032
+    SDValue ZeroC =  DAG.getIntPtrConstant(0, dl); 
     SDValue AllZeros = DAG.getSplatBuildVector(ResVT, dl, ZeroC);
     return DAG.getNode(ISD::INSERT_SUBVECTOR, dl, ResVT, AllZeros, Promoted,
----------------
Please just use getZeroVector() for consistency.


https://reviews.llvm.org/D38689





More information about the llvm-commits mailing list