[PATCH] D31530: [ARM] Use new assembler diags for ARM

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

Yes, I agree that it would be good to get this turned on for all targets. I'm developing it on ARM only at the moment so that I can make changes to the general mechanism without breaking lots of target's tests. Once it's stabilised, here's what I think needs doing to use it for other targets:

- Move the ReportNearMisses and FilterNearMisses from the ARM asm parser to somewhere target-independent. There is some ARM-specific code in there at the moment, so this will need some sort of callbacks into the target asm parser.
- Switch each asm parser to use the new mechanism. This should involve changing the signature of MatchInstruction, implementing any target-specific callbacks needed, and flipping the bit in the tablegen. I think the biggest part of this work will be updating the tests to match the new diagnostic format.

I plan on doing this for AArch64 once I'm done with ARM, but I'm not sure I know enough about the other targets assembly to be able to update the tests myself.


Repository:
  rL LLVM

https://reviews.llvm.org/D31530