[PATCH] D38260: [llvm-objcopy] Add support for removing sections

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 10 02:45:02 PDT 2017


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, aside from one comment addition.



================
Comment at: test/tools/llvm-objcopy/remove-section-with-symbol.test:31
+
+#CHECK: SectionHeaderCount: 5
+
----------------
Could you add a comment saying what the other 4 section headers should be, please, to avoid confusion (I assume it is null, .symtab, .strtab, and .shstrtab).


Repository:
  rL LLVM

https://reviews.llvm.org/D38260





More information about the llvm-commits mailing list