[PATCH] D38712: [ELF] Try to not emit weird diagnostics on undefined symbols

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: ELF/Relocations.cpp:865-866
 
+      // If we report an undefined, and we have an error, go on.
+      if (ErrorCount)
+        continue;
----------------
ruiu wrote:
> davide wrote:
> > ruiu wrote:
> > > Can you just continue without checking for ErrorCount?
> > Not quite :(
> > 
> > ********************
> > Testing Time: 2.76s
> > ********************
> > Failing Tests (36):
> Why are they failing?
Because recordUndefined is not a function returning a boolean which communicates to the caller whether the reported symbol was actually undefined, it just does side effect calling error (or warn).


https://reviews.llvm.org/D38712