[PATCH] D38712: [ELF] Try to not emit weird diagnostics on undefined symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 19:52:10 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:865-866
 
+      // If we report an undefined, and we have an error, go on.
+      if (ErrorCount)
+        continue;
----------------
davide wrote:
> ruiu wrote:
> > Can you just continue without checking for ErrorCount?
> Not quite :(
> 
> ********************
> Testing Time: 2.76s
> ********************
> Failing Tests (36):
Why are they failing?


https://reviews.llvm.org/D38712





More information about the llvm-commits mailing list