[PATCH] D38686: [dsymutil] Timestmap verification for __swift_ast

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/tools/dsymutil/ARM/swift-ast.test:1
+RUN: llvm-dsymutil -oso-prepend-path %p/.. %p/../Inputs/swift-ast.macho.fat -o %T/swift-ast.dSYM -verbose -no-swiftmodule-timestamp | FileCheck %s --check-prefix=DSYMUTIL
+RUN: llvm-readobj -sections -section-data %T/swift-ast.dSYM/Contents/Resources/DWARF/swift-ast.macho.fat | FileCheck %s --check-prefix=READOBJ
----------------
JDevlieghere wrote:
> aprantl wrote:
> > if the test is disabling the new functionality (`-no-swiftmodule-timestamp`) what is it testing?
> I used this to verify my implementation locally, and figured I might as well upstream it as it covers two scenarios (arm & universal mach-o) not covered by the existing test. Let me know if you would leave this out or have it moved into in a separate commit. 
the extra test is fine, I was just wondering if the test shouldn't be testing for the "Timestamp mismatch" warning.


https://reviews.llvm.org/D38686