[PATCH] D38466: [ TargetLowering, AMDGPU] Use the return value of UpdateNodeOperands();

[Mark Searles via Phabricator via llvm-commits]

msearles marked an inline comment as done.
msearles added inline comments.


================
Comment at: test/CodeGen/AMDGPU/simplifydemandedbits-recursion.ll:1
+; RUN: (ulimit -t 5; llc -march=amdgcn < %s | FileCheck -check-prefix=GCN %s)
+
----------------
RKSimon wrote:
> msearles wrote:
> > msearles wrote:
> > > RKSimon wrote:
> > > > arsenm wrote:
> > > > > Does this actually work? I've never seen another test use ulimit or a sub shell. 5 seconds seems high also.
> > > > Does this work on windows builds?
> > > Nope; will not work on Windows; test adjusted.
> > Yes, it works quite nicely on Linux; it will not work on Windows (thanks Simon) as ulimit is not available. I removed the ulimit. So, potentially, there may be a compiler regression that causes this to loop infinitely; however, I think that you could say that about any test. 
> Remove the brackets? Also, drop the prefix and use the default 'CHECK' ?
Done and done.


https://reviews.llvm.org/D38466