[PATCH] D38405: [ThinLTO] Use decimal suffix for promoted values to match demanglers

[David Blaikie via llvm-commits]

Test case?

On Fri, Sep 29, 2017 at 8:08 AM Teresa Johnson via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> tejohnson created this revision.
> Herald added a subscriber: inglorion.
>
> Demanglers such as libiberty know how to strip suffixes of the form
> \.[a-zA-Z]+\.\d+, but our current promoted value suffixes are
> .llvm.${modulehash}, where the module hash is in hex. Change the
> module hash to decimal to allow demanglers to handle this.
>
>
> https://reviews.llvm.org/D38405
>
> Files:
>   include/llvm/IR/ModuleSummaryIndex.h
>
>
> Index: include/llvm/IR/ModuleSummaryIndex.h
> ===================================================================
> --- include/llvm/IR/ModuleSummaryIndex.h
> +++ include/llvm/IR/ModuleSummaryIndex.h
> @@ -743,7 +743,7 @@
>    static std::string getGlobalNameForLocal(StringRef Name, ModuleHash
> ModHash) {
>      SmallString<256> NewName(Name);
>      NewName += ".llvm.";
> -    NewName += utohexstr(ModHash[0]); // Take the first 32 bits
> +    NewName += utostr(ModHash[0]); // Take the first 32 bits
>      return NewName.str();
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171009/8efccbce/attachment.html>