[PATCH] D38681: [LLD] [COFF] Don't error out on relocations to discarded sections in .eh_frame

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 9 10:05:24 PDT 2017


rnk added a comment.

lgtm, this is consistent with this comment in the ELF side:

  // .eh_frame is horribly special and can reference discarded sections. To
  // avoid having to parse and recreate .eh_frame, we just replace any
  // relocation in it pointing to discarded sections with R_*_NONE, which
  // hopefully creates a frame that is ignored at runtime.

We might want to start using associative comdats to avoid making object files like this on win64, though.


https://reviews.llvm.org/D38681





More information about the llvm-commits mailing list