[PATCH] D38424: MC Helpers for llvm-cfi-verify.

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: tools/llvm-cfi-verify/FileAnalysis.cpp:149
+  const auto &InstrDesc = MII->get(InstrMeta.Instruction.getOpcode());
+  if (InstrDesc.mayAffectControlFlow(InstrMeta.Instruction, *RegisterInfo)) {
+    if (InstrDesc.isConditionalBranch())
----------------
Make this an if{}else{} that calculates a `uint64_t Target` so that the identical tails can be merged?


================
Comment at: tools/llvm-cfi-verify/FileAnalysis.h:103
+  // well as the previous instruction if it can fall through.
+  std::set<const Instr *> getControlFlowXRefs(const Instr &InstrMeta) const;
+
----------------
`getDirectControlFlowXRefs()`?


https://reviews.llvm.org/D38424