[PATCH] D38687: [ELF] Make section order rely on explicit member

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D38687#891902, @peter.smith wrote:

> One possible downside is OutSecPos will only be set for InputSections added via addSection(), ThunkSections and any other late inserted sections won't have this set. This isn't necessarily a problem as inserting sections doesn't change the relative ordering of any existing InputSections, however I think we need to either comment that OutSecPos is not set for inserted sections such as Thunks, or make AssignAddresses update the OutSecPos.
>
>     


I think, until there is a concrete use case for this in thunk sections etc. that I prefer not to update this during assignAddresses to keep things simpler. I'm not opposed to that though if it becomes necessary later on.


https://reviews.llvm.org/D38687