[PATCH] D38586: SLPVectorizer.cpp: Ensure SLPVectorizer can visit each block by dominated order

[Daniel Berlin via llvm-commits]

Imho:  It should be trivial to fix this, and we shouldn't hack around it.

On Fri, Oct 6, 2017, 10:46 PM Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added a comment.
>
> In https://reviews.llvm.org/D38586#891283, @chapuni wrote:
>
> > The test added. This comes from EmitAtomicUpdateValue() in CGAtomic.cpp.
> >  I confirmed it fails on both libstdc++ and libc++ to me.
> >
> > I will attempt to get rid of O(N^2) there, but I think it'd not be big
> deal unless preds exceeded hundreds.
>
>
> I really think we should try to at least make an attempt to get rid of the
> O(N^2) behaviour as it doesn't seem terribly complicated to do so _and_ it
> may bite us in the future in many unexpected ways. The test seems fine, but
> you can probably clean it up a bit (and run metarenamer on it for shorter
> names)
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D38586
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171007/593df84b/attachment.html>