[debuginfo-tests] r300467 - Revert "Revert "Add a test for __block variables + asan.""

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 21:04:43 PDT 2017


Hey Adrian,

Could you share where the "not_asan" lit feature is defined? I'm running into some problems with it.

Specifically the code coverage bot defines "not_asan" (somehow.. not sure how yet!), even though it doesn't build the ASan runtime. This is causing the bot to break.

http://green.lab.llvm.org/green//job/clang-stage2-coverage-R/1801 <http://green.lab.llvm.org/green//job/clang-stage2-coverage-R/1801>

vedant

> On Apr 17, 2017, at 10:57 AM, Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: adrian
> Date: Mon Apr 17 12:57:01 2017
> New Revision: 300467
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=300467&view=rev
> Log:
> Revert "Revert "Add a test for __block variables + asan.""
> 
> This reapplies commit r300228.
> 
> Modified:
>    debuginfo-tests/trunk/asan.c
>    debuginfo-tests/trunk/llgdb.py
> 
> Modified: debuginfo-tests/trunk/asan.c
> URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/asan.c?rev=300467&r1=300466&r2=300467&view=diff
> ==============================================================================
> --- debuginfo-tests/trunk/asan.c (original)
> +++ debuginfo-tests/trunk/asan.c Mon Apr 17 12:57:01 2017
> @@ -3,24 +3,38 @@
> // REQUIRES: not_asan
> //           Zorg configures the ASAN stage2 bots to not build the asan
> //           compiler-rt. Only run this test on non-asanified configurations.
> -//
> -// DEBUGGER: break 24
> -// DEBUGGER: r
> -// DEBUGGER: p s
> -//
> -// CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
> -
> +void b();
> struct S {
>   int a[8];
> };
> 
> int f(struct S s, unsigned i) {
> +  // DEBUGGER: break 16
> +  // DEBUGGER: r
> +  // DEBUGGER: p s
> +  // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
>   return s.a[i];
> }
> 
> int main(int argc, const char **argv) {
>   struct S s = {{0, 1, 2, 3, 4, 5, 6, 7}};
> -  if (f(s, 4) == 4)
> -    return f(s, 0);
> +  if (f(s, 4) == 4) {
> +    // DEBUGGER: break 26
> +    // DEBUGGER: c
> +    // DEBUGGER: p s
> +    // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)
> +    b();
> +  }
>   return 0;
> }
> +
> +void c() {}
> +
> +void b() {
> +  // DEBUGGER: break 39
> +  // DEBUGGER: c
> +  // DEBUGGER: p x
> +  // CHECK: 42
> +  __block int x = 42;
> +  c();
> +}
> 
> Modified: debuginfo-tests/trunk/llgdb.py
> URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/llgdb.py?rev=300467&r1=300466&r2=300467&view=diff
> ==============================================================================
> --- debuginfo-tests/trunk/llgdb.py (original)
> +++ debuginfo-tests/trunk/llgdb.py Mon Apr 17 12:57:01 2017
> @@ -139,6 +139,10 @@ NOTE: There are several reasons why this
>             frame = thread.GetFrameAtIndex(0)
>             print frame.EvaluateExpression(' '.join(cmd[1:]))
> 
> +        elif re.match('^n|(next)$', cmd[0]):
> +            thread = process.GetThreadAtIndex(0)
> +            thread.StepOver()
> +
>         elif re.match('^q|(quit)$', cmd[0]):
>             sys.exit(0)
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171006/d4f9b161/attachment.html>


More information about the llvm-commits mailing list