[PATCH] D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 17:57:39 PDT 2017


hctim created this revision.

cl::opt<uint64_t> fails when parsing command line arguments.

See https://bugs.llvm.org/show_bug.cgi?id=19665.


https://reviews.llvm.org/D38657

Files:
  tools/llvm-cfi-verify/FileAnalysis.cpp
  tools/llvm-cfi-verify/GraphBuilder.cpp
  tools/llvm-cfi-verify/GraphBuilder.h


Index: tools/llvm-cfi-verify/GraphBuilder.h
===================================================================
--- tools/llvm-cfi-verify/GraphBuilder.h
+++ tools/llvm-cfi-verify/GraphBuilder.h
@@ -46,8 +46,8 @@
 namespace llvm {
 namespace cfi_verify {
 
-extern uint64_t SearchLengthForUndef;
-extern uint64_t SearchLengthForConditionalBranch;
+extern unsigned long long SearchLengthForUndef;
+extern unsigned long long SearchLengthForConditionalBranch;
 
 struct ControlFlowNode {
   void printControlFlowNode(unsigned depth, raw_ostream& os) const;
Index: tools/llvm-cfi-verify/GraphBuilder.cpp
===================================================================
--- tools/llvm-cfi-verify/GraphBuilder.cpp
+++ tools/llvm-cfi-verify/GraphBuilder.cpp
@@ -41,17 +41,17 @@
 namespace llvm {
 namespace cfi_verify {
 
-uint64_t SearchLengthForUndef;
-uint64_t SearchLengthForConditionalBranch;
+unsigned long long SearchLengthForUndef;
+unsigned long long SearchLengthForConditionalBranch;
 
-static cl::opt<uint64_t, true> SearchLengthForUndefArg(
+static cl::opt<unsigned long long, true> SearchLengthForUndefArg(
     "search-length-undef",
     cl::desc("Specify the maximum amount of instructions "
              "to inspect when searching for an undefined "
              "instruction from a conditional branch."),
     cl::location(SearchLengthForUndef), cl::init(2));
 
-static cl::opt<uint64_t, true> SearchLengthForConditionalBranchArg(
+static cl::opt<unsigned long long, true> SearchLengthForConditionalBranchArg(
     "search-length-cb",
     cl::desc("Specify the maximum amount of instructions "
              "to inspect when searching for a conditional "
Index: tools/llvm-cfi-verify/FileAnalysis.cpp
===================================================================
--- tools/llvm-cfi-verify/FileAnalysis.cpp
+++ tools/llvm-cfi-verify/FileAnalysis.cpp
@@ -50,7 +50,7 @@
     cl::desc("Ignore all DWARF data (warning: may generate false positives)."),
     cl::location(IgnoreDWARF), cl::init(false));
 
-cl::opt<uint64_t> DWARFSearchRange(
+cl::opt<unsigned long long> DWARFSearchRange(
     "dwarf-search-range",
     cl::desc("Address search range used to determine if instruction is valid."),
     cl::init(0x10));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38657.118117.patch
Type: text/x-patch
Size: 2237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171007/bc792b09/attachment.bin>


More information about the llvm-commits mailing list