[PATCH] D36627: dwarfdump: Add an option to collect debug info quality metrics

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D36627#888477, @aprantl wrote:

> In https://reviews.llvm.org/D36627#880222, @aprantl wrote:
>
> > pinging @dblaikie.
>
>
> ping.


@dblaikie is at a conference. I think we should go ahead and land this and iterate. It's a testing tool anyway. Looks good!



================
Comment at: tools/llvm-dwarfdump/Statistics.cpp:175-176
+///
+/// Do the impossible and reduce the quality of the debug info down to a few
+/// numbers. The idea is to condense the data into numbers that can be tracked
+/// over time to identify trends in newer compiler versions and gauge the effect
----------------
This sentence needs editting, I think it's supposed to say, "It's impossible to reduce ..."


https://reviews.llvm.org/D36627