[lld] r315073 - [ELF][MIPS] Check for overflow when writing R_MIPS_CALL16 and R_MIPS_TLS_GOTTPREL

[Alexander Richardson via llvm-commits]

Author: arichardson
Date: Fri Oct  6 09:15:59 2017
New Revision: 315073

URL: http://llvm.org/viewvc/llvm-project?rev=315073&view=rev
Log:
[ELF][MIPS] Check for overflow when writing R_MIPS_CALL16 and R_MIPS_TLS_GOTTPREL

Summary:
These are 16 bit relocations and not part of a HI/LO pair so we need to
check that they don't overflow.

Reviewers: atanasyan

Reviewed By: atanasyan

Subscribers: ruiu, llvm-commits, emaste, sdardis

Tags: #lld

Differential Revision: https://reviews.llvm.org/D38614

Added:
    lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s
Modified:
    lld/trunk/ELF/Arch/Mips.cpp

Modified: lld/trunk/ELF/Arch/Mips.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/Mips.cpp?rev=315073&r1=315072&r2=315073&view=diff
==============================================================================
--- lld/trunk/ELF/Arch/Mips.cpp (original)
+++ lld/trunk/ELF/Arch/Mips.cpp Fri Oct  6 09:15:59 2017
@@ -501,21 +501,21 @@ void MIPS<ELFT>::relocateOne(uint8_t *Lo
       writeMicroRelocation32<E>(Loc, Val, 16, 0);
     }
     break;
+  case R_MIPS_CALL16:
   case R_MIPS_GOT_DISP:
   case R_MIPS_GOT_PAGE:
   case R_MIPS_GPREL16:
   case R_MIPS_TLS_GD:
+  case R_MIPS_TLS_GOTTPREL:
   case R_MIPS_TLS_LDM:
     checkInt<16>(Loc, Val, Type);
     LLVM_FALLTHROUGH;
-  case R_MIPS_CALL16:
   case R_MIPS_CALL_LO16:
   case R_MIPS_GOT_LO16:
   case R_MIPS_GOT_OFST:
   case R_MIPS_LO16:
   case R_MIPS_PCLO16:
   case R_MIPS_TLS_DTPREL_LO16:
-  case R_MIPS_TLS_GOTTPREL:
   case R_MIPS_TLS_TPREL_LO16:
     writeRelocation<E>(Loc, Val, 16, 0);
     break;

Added: lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s?rev=315073&view=auto
==============================================================================
--- lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s (added)
+++ lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s Fri Oct  6 09:15:59 2017
@@ -0,0 +1,29 @@
+# Check that we create an error on an out-of-bounds R_MIPS_CALL_16
+
+# REQUIRES: mips
+# RUN: llvm-mc -filetype=obj -triple=mips64-unknown-linux %s -o %t1.o
+# RUN: not ld.lld %t1.o -o %t.exe 2>&1 | FileCheck %s
+
+# CHECK: relocation R_MIPS_CALL16 out of range
+
+.macro generate_values
+  .irp i, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+    .irp j, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+      .irp k, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+        .irp l, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+          .text
+          .globl sym_\i\j\k\l
+          sym_\i\j\k\l:
+          nop
+          lw $25,%call16(sym_\i\j\k\l)($28)
+        .endr
+      .endr
+    .endr
+  .endr
+.endm
+
+generate_values
+
+.globl __start
+__start:
+  nop