[PATCH] D38622: [GlobalISel] Fix legalizer trying to process a deleted instruction

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 06:09:05 PDT 2017


aemerson added a subscriber: llvm-commits.
aemerson added a comment.

Forgot to add llvm-commits, pasting description again:

[GlobalISel] Fix legalizer trying to process a deleted instruction.

In some cases an instruction is deleted from the block during combining, however it can still exist in the legalizer worklist.

This change modifies the combiner routines to add the given MI to the dead instruction list rather than trying to remove it from the block themselves. The responsibility is then on the caller to delete the instruction from the block and any worklists.

This bug was exposed by https://reviews.llvm.org/D38621 on a test suite build.


Repository:
  rL LLVM

https://reviews.llvm.org/D38622





More information about the llvm-commits mailing list