[PATCH] D38580: [ELF] - Do not produce broken .dynamic section with --no-rosegment

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 19:50:15 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:1174
 
-  getParent()->Link = this->Link;
+  add({DT_NULL, 0ULL});
 
----------------
Look at line 1073 (it is always good to look around when you add code to an existing file). For consistency, 0ULL -> (uint64_t)0.


https://reviews.llvm.org/D38580





More information about the llvm-commits mailing list