[PATCH] D38608: [sanitizer] Test ubsan and cfi on android.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/test/cfi/stats.cpp:7
 // UNSUPPORTED: devirt
+// UNSUPPORTED: android
 
----------------
pcc wrote:
> Do you know why it fails?
Because sanstats input is not transferred back to host :) It's a general issue in lit tests, I'd assume more than half cases of "UNSUPPORTED: android" are caused by this or a related problem.


================
Comment at: compiler-rt/test/ubsan/TestCases/TypeCheck/Function/function.cpp:6
+//
+// UNSUPPORTED: android
 
----------------
pcc wrote:
> Presumably this fails when targeting ARM?
> 
> Should we instead adjust this to check target instead of host?
> http://llvm-cs.pcc.me.uk/projects/compiler-rt/test/ubsan/TestCases/TypeCheck/Function/lit.local.cfg
Oh right, it's not about Android. Function sanitizer is not supported on ARM.


https://reviews.llvm.org/D38608