[PATCH] D38598: [llvm-objdump] Add RAII for xar apis

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 14:25:04 PDT 2017


alexshap added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:211
+  }
+  ~ScopedXarFile() { xar_close(xar); }
+  operator xar_t() { return xar; }
----------------
just to double check - does xar_close work fine with nulls ? (i.e. if xar_open has failed)


https://reviews.llvm.org/D38598





More information about the llvm-commits mailing list