[PATCH] D38598: [llvm-objdump] Add RAII for xar apis

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 14:08:40 PDT 2017


alexshap added inline comments.


================
Comment at: tools/llvm-objdump/MachODump.cpp:205
 
+struct XarFile {
+  xar_t xar;
----------------
compnerd wrote:
> Can you please call this `ScopedXarFile`?
this probably should be in the anonymous namespace


https://reviews.llvm.org/D38598





More information about the llvm-commits mailing list