[PATCH] D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 13:19:08 PDT 2017


kuhar added a comment.

With your patch, `FindPhiPredForUseInBlock` becomes unused and it causes the following warning to be emitted:

  llvm/lib/Transforms/Utils/CodeExtractor.cpp:657:20: warning: unused function 'FindPhiPredForUseInBlock' [-Wunused-function]
  static BasicBlock* FindPhiPredForUseInBlock(Value* Used, BasicBlock* BB) {

And that would make many buildbots very grumpy :)
I think that the function should be now deleted, as it has no users.


https://reviews.llvm.org/D37902





More information about the llvm-commits mailing list