[PATCH] D38526: [asan] Use full binary path in the Android test runner.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 5 12:47:44 PDT 2017


eugenis added inline comments.


================
Comment at: compiler-rt/test/sanitizer_common/android_commands/android_common.py:12
+def host_to_device_path(path):
+    rel = os.path.relpath(path, "/")
+    dev = os.path.join(ANDROID_TMPDIR, rel)
----------------
vitalybuka wrote:
> Thy this is relative to the / and not to maybe build root?
This is more reliable, for example, you may run tests from two build trees on one device at the same time. Also, it is easier to implement - otherwise we would need to pass the build root to the script somehow.



https://reviews.llvm.org/D38526





More information about the llvm-commits mailing list