[PATCH] D35413: [LLD][ELF] Add DefinedInThunk to SymbolBody to remove need for hash lookup

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

> The use of the hash table and the proposed new member is so that, for
>  example, two arm relocations to a thumb function use a single thunk,
>  correct?
> 
> If so the hash table is only needed during the one pass when we are
>  mutating relocations to point to the thunk.
> 
> If the above is correct, a hash table seems better IMHO since it is only
>  used in a very specific point in the code.
> 
> Cheers,
> Rafael

Yes it is only used within createThunks(). This review was created in response to a review comment in one of the previous range-thunks patches (still in review) https://reviews.llvm.org/D34692#809065 expressing a preference for avoiding the hash table lookup. Personally I prefer the hash table lookup as well but I've not got a strong preference. My main concern is getting the range-thunks functionality in.


https://reviews.llvm.org/D35413