[PATCH] D38575: [PowerPC] Recommit r314244 with refactoring and off by default

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:108
+
+static cl::opt<ICmpInGPRType> CmpInGPR(
+  "ppc-gpr-icmps", cl::Hidden, cl::init(ICGPR_None),
----------------
The various values provided here do not have adequate testing as they are not meant to stay in - they're only provided to aid in field-testing this patch.

If we can settle on which of these we want to keep permanently (and if we want to add any), then I'll provide testing for those and make sure I keep them in even after we turn this on by default.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2106
 
+class IntegerCompareEliminator {
+  SelectionDAG *CurDAG;
----------------
Feel free to chime in with suggestions if you don't like the name. Perhaps a more appropriate name would be `IntegerCompareSelector` or similar.


Repository:
  rL LLVM

https://reviews.llvm.org/D38575