[PATCH] D38554: Fixed ppc32 function relocations in non-pic mode

vit9696 via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 15:41:12 PDT 2017


vit9696 added a comment.

In https://reviews.llvm.org/D38554#888873, @joerg wrote:

> In that case: the short version is that there is no EABI support at the moment. That patch changes the behavior for SYSV ABI, it is not acceptable as such. The test case doesn't reflect the ABI variance either.


May I please ask you a second time, where did the behaviour change, so that I could address the issue. At the moment I do not see it. If SYSV ABI uses PIC, then DAG.getTarget().getRelocationModel() == Reloc::PIC_ will not affect it anyhow. 
If you imply that it changes the behaviour for static relocation model (i.e. the one that has PIC disabled), then it is intended, since it is a fix to a regression introduced a year ago.


https://reviews.llvm.org/D38554





More information about the llvm-commits mailing list