[PATCH] D38565: [lit] Improve the ToolSubst class a bit

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 15:36:35 PDT 2017


zturner created this revision.
Herald added a reviewer: modocache.

In a separate patch, I'm working on re-working clang and lld's lit config's to call a common `use_clang` and `use_lld` functions, respectively.  Making this work and be generic enough that it also supports `debuginfo-test`'s use case requires a little bit more power in how we specify a tool substitution.  For example, `lld` doesn't prefix its tool substitutions with `%`, but clang does.  And `debuginfo-tests` shouldn't fail if `lld` can't be found, but obviously `lld` should.

This patch adds the necessary bits to make this possible.

It also renames `ToolFilter` to `ToolSubst`, and moves it to its own file, to avoid a cyclic dependency between `__init__.py` and the other files in the same module.


https://reviews.llvm.org/D38565

Files:
  clang/test/lit.cfg.py
  lld/test/lit.cfg.py
  llvm/test/lit.cfg.py
  llvm/utils/lit/lit/llvm/__init__.py
  llvm/utils/lit/lit/llvm/config.py
  llvm/utils/lit/lit/llvm/subst.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38565.117751.patch
Type: text/x-patch
Size: 13667 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171004/cf4490df/attachment.bin>


More information about the llvm-commits mailing list