[PATCH] D38556: AMDGPU: Add and set AMDGPU-specific e_flags

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 12:59:49 PDT 2017


t-tye added inline comments.


================
Comment at: include/llvm/BinaryFormat/ELF.h:651
+// AMDGPU Specific e_flags
+enum : unsigned {
+  EF_AMDGPU_ARCH_NONE = 0x00000000, // None/unknown.
----------------
```
// AMDGPU machine architectures.
```


================
Comment at: include/llvm/BinaryFormat/ELF.h:652-655
+  EF_AMDGPU_ARCH_NONE = 0x00000000, // None/unknown.
+  EF_AMDGPU_ARCH_R600 = 0x10000000, // AMD HD2XXX-HD6XXX GPUs.
+  EF_AMDGPU_ARCH_GCN = 0x20000000,  // AMD GCN GFX6+ GPUs.
+  EF_AMDGPU_ARCH = 0xf0000000       // EF_AMDGPU_ARCH_XXX selection mask.
----------------
Suggest moving to the lower 4 bits.


https://reviews.llvm.org/D38556





More information about the llvm-commits mailing list