[PATCH] D38407: [ELF] - Do --hash-style=both by default.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:267
+// combinations and adjusts the configuration if needed.
+static void finalizeOptions(opt::InputArgList &Args) {
   // The MIPS ABI as of 2016 does not support the GNU-style symbol lookup
----------------
No, please do not make a change to this function like this, but instead keep it side-effect-free except calling error(). This change hurts readability.


https://reviews.llvm.org/D38407