[PATCH] D38540: Ignore duplicated, identical fragment declarations
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 4 09:03:02 PDT 2017
rnk added a comment.
`DbgVariable::addMMIEntry` already handles de-duplication of non-fragment FrameIndexExprs, so I think we should put the logic for frame index exprs there. In fact, what you're doing here is plainly more general the special case code that we have there, and we should be able to get rid of it.
I'd also move `addMMIEntry` out of line. It has clearly grown in complexity over time.
https://reviews.llvm.org/D38540
More information about the llvm-commits
mailing list