[PATCH] D38542: [test] Fix ASAN_OPTIONS to prevent adding trailing semicolon

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 4 07:54:23 PDT 2017


fjricci created this revision.
Herald added a reviewer: modocache.

append_path adds a trailing semicolon to the environment variable,
which will break ASAN_OPTIONS.


https://reviews.llvm.org/D38542

Files:
  utils/lit/lit/llvm/config.py


Index: utils/lit/lit/llvm/config.py
===================================================================
--- utils/lit/lit/llvm/config.py
+++ utils/lit/lit/llvm/config.py
@@ -77,7 +77,7 @@
         if target_triple:
             if re.match(r'^x86_64.*-apple', target_triple):
                 if 'address' in sanitizers:
-                    self.with_environment('ASAN_OPTIONS', 'detect_leaks=1', append_path=True)
+                    self.with_environment('ASAN_OPTIONS', 'detect_leaks=1')
             if re.match(r'^x86_64.*-linux', target_triple):
                 features.add("x86_64-linux")
             if re.match(r'.*-win32$', target_triple):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38542.117672.patch
Type: text/x-patch
Size: 655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171004/45740700/attachment.bin>


More information about the llvm-commits mailing list