[PATCH] D38496: [XRay] [test-suite] Add litsupport for microbenchmarks

[Eizan Miyamoto via Phabricator via llvm-commits]

eizan updated this revision to Diff 117648.
eizan added a comment.

add microbenchmark module after run and remove timeit from XRay/lit.local.cfg


https://reviews.llvm.org/D38496

Files:
  MicroBenchmarks/XRay/lit.local.cfg
  litsupport/modules/microbenchmark.py


Index: litsupport/modules/microbenchmark.py
===================================================================
--- /dev/null
+++ litsupport/modules/microbenchmark.py
@@ -0,0 +1,46 @@
+'''Test module to collect google benchmark results.'''
+from litsupport import shellcommand
+from litsupport import testplan
+import csv
+import lit.Test
+
+
+def _mutateCommandLine(context, commandline):
+    cmd = shellcommand.parse(commandline)
+    cmd.arguments.append("--benchmark_format=csv")
+    # We need stdout outself to get the benchmark csv data.
+    if cmd.stdout is not None:
+        raise Exception("Rerouting stdout not allowed for microbenchmarks")
+    benchfile = context.tmpBase + '.bench.csv'
+    cmd.stdout = benchfile
+    context.microbenchfiles.append(benchfile)
+
+    return cmd.toCommandline()
+
+
+def _mutateScript(context, script):
+    return testplan.mutateScript(context, script, _mutateCommandLine)
+
+
+def _collectMicrobenchmarkTime(context, microbenchfiles):
+    result = 0.0
+    for f in microbenchfiles:
+        with open(f) as inp:
+            lines = csv.reader(inp)
+            # First line: "name,iterations,real_time,cpu_time,time_unit..."
+            for line in lines:
+                if line[0] == 'name':
+                    continue
+                # Note that we cannot create new tests here, so for now we just
+                # add up all the numbers here.
+                result += float(line[3])
+    return {'microbenchmark_time_ns': lit.Test.toMetricValue(result)}
+
+
+def mutatePlan(context, plan):
+    context.microbenchfiles = []
+    plan.runscript = _mutateScript(context, plan.runscript)
+    plan.metric_collectors.append(
+        lambda context: _collectMicrobenchmarkTime(context,
+                                                   context.microbenchfiles)
+    )
Index: MicroBenchmarks/XRay/lit.local.cfg
===================================================================
--- MicroBenchmarks/XRay/lit.local.cfg
+++ MicroBenchmarks/XRay/lit.local.cfg
@@ -1 +1,8 @@
 config.environment['XRAY_OPTIONS'] = 'patch_premain=false xray_naive_log=false'
+test_modules = config.test_modules
+if 'run' in test_modules:
+    # Insert microbenchmark module behind 'run'
+    test_modules.insert(test_modules.index('run')+1, 'microbenchmark')
+    # Timeit results are not useful for microbenchmarks
+    if 'timeit' in test_modules:
+        test_modules.remove('timeit')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38496.117648.patch
Type: text/x-patch
Size: 2432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171004/08b09712/attachment.bin>