[PATCH] D38486: [PPC] Implement the heuristic to choose between a X-Form VSX ld/st vs a X-Form FP ld/st.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:3089
 
-  let Predicates = [HasVSX, NoP9Vector] in {
+  let Predicates = [HasVSX/*, NoP9Vector*/] in {
     // Load-and-splat with fp-to-int conversion (using X-Form VSX loads).
----------------
jtony wrote:
> Do we really need the NoP9Vector here ? If not, I can remove it.
If we don't have it, won't this pattern compete with the DblToIntLoadP9 pattern on the `P9`?Maybe the complexity metric will make the latter win, but it probably makes sense to leave the NoP9Vector here so that it's explicit.

Otherwise, this LGTM.



https://reviews.llvm.org/D38486