[PATCH] D38505: [ELF] - Get rid of precompiled input objects from testcases.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 3 16:26:24 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you for doing this.



================
Comment at: test/ELF/verneed-as-needed-weak.s:2-3
 # REQUIRES: x86
+# RUN: echo "v1 {}; v2 {}; v3 { local: *; };" > %t.script
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/verneed1.s -o %t1.o
+# RUN: ld.lld -shared %t1.o --version-script %t.script -o %t.so
----------------
Swap these two lines because the second line does not depend on the first line.


================
Comment at: test/ELF/verneed.s:2-3
 # REQUIRES: x86
+# RUN: echo "v1 {}; v2 {}; v3 { local: *; };" > %t.script
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/verneed1.s -o %t1.o
+# RUN: ld.lld -shared %t1.o --version-script %t.script -o %t1.so -soname verneed1.so.0
----------------
Ditto


https://reviews.llvm.org/D38505





More information about the llvm-commits mailing list